[CentOS-devel] [PATCH] Clean up temp src.rpm

Wed Jun 11 17:32:45 UTC 2014
Karanbir Singh <mail-lists at karan.org>

On 06/11/2014 06:30 PM, Pat Riehecky wrote:
> On 06/11/2014 12:27 PM, Pat Riehecky wrote:
>> On 06/11/2014 12:24 PM, Karanbir Singh wrote:
>>> Hi
>>>
>>> On 06/11/2014 04:45 PM, Pat Riehecky wrote:
>>>> From: Pat Riehecky <riehecky at fnal.gov>
>>>>
>>>> --- return_disttag.sh |    3 +++ 1 files changed, 3 insertions(+),
>>>> 0 deletions(-)
>>>>
>>>> diff --git a/return_disttag.sh b/return_disttag.sh index
>>>> f7dc610..f850356 100755 --- a/return_disttag.sh +++
>>>> b/return_disttag.sh @@ -73,6 +73,9 @@ nvr1="${pkg%.src.rpm}"
>>>> mydist="XXXjsdf9ur7qlkasdh4gygXXX" nvr2=$(rpm --define "dist
>>>> $mydist" -q --specfile "SPECS/$packagename.spec" --qf
>>>> '%{n}-%{v}-%{r}\n' 2>/dev/null | head -n 1)
>>> this should not really create the srpm should it ?
>>>
>>>> +# clean up SRPM, since it is only used for its name +rm -f ${nvr2}
>>>>> /dev/null 2>&1
>>> not sure what needs removing here..
>>>
>> When I ran it on an SL5 I ended up with an appropriately named file.
>> I'll confess I didn't chase down the ultimate cause, could be my testvm
>> needs to be reloaded (I've been messing with it more than a little).  I
>> didn't get such a file on SL6 or RHEL7 RC.
>>
>> Pat
>>
> Yep, its my VM.
> 
> NACK this patch.

done.


-- 
Karanbir Singh
+44-207-0999389 | http://www.karan.org/ | twitter.com/kbsingh
GnuPG Key : http://www.karan.org/publickey.asc