<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 15, 2016 at 5:55 PM, Troy Dawson <span dir="ltr"><<a href="mailto:tdawson@redhat.com" target="_blank">tdawson@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
I've been debating this all week and decided it's probably better as a<br>
community decision than just my own.<br>
<br>
Problem:<br>
The current source rpm for origin is generated using tito on the<br>
origin git repo. The biggest problem with this is the tarball is<br>
generated on the fly and sortof encorporated into the spec file. That<br>
makes it hard for others to duplicate the src.rpm and/or make patches<br>
for it.<br>
<br>
If I were an outsider (not on the openshift team) and making an rpm<br>
for Fedora/EPEL, I wouldn't do this. I would grab the released<br>
tarball from Github and build my spec file around that.<br>
<br>
Solution 1:<br>
Keep things the same.<br>
Do others really care that they can't duplicate the src.rpm without<br>
tito, as long as they can recompile it?<br></blockquote><div><br></div><div>Personally, I like this approach since it integrates with rhpkg/fedpkg very well. I'm not sure if CentOS has a similar tool that provides dist-git alongside koji, but I like the idea of being able to leverage the same spec file for all builds.</div><div><br></div><div>That said, I do wonder if providing a tool that could "convert" the tito managed spec file to one that can be run outside of tito would be beneficial.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Solution 2:<br>
Create a origin spec file that uses the tarball from Github.<br>
I've already done this. It works quite well. But it does involve<br>
some manual spec file editing.<br>
<br>
Troy<br>
p.s. I am totally fine either way. The only reason I've been debating<br>
this is because I keep having issues with tito making the whole<br>
src.rpm.<br></blockquote><div><br></div><div>cc'ing Devan Goodwin, since he knows a bit about tito. I'm also cc'ing Adam Miller, since I know he is packaging OpenShift Origin for Fedora.</div></div><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Jason DeTiberus<br></div></div>
</div></div>