<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 16, 2016 at 12:43 PM, Clint Savage <span dir="ltr"><<a href="mailto:herlo1@gmail.com" target="_blank">herlo1@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Here's the problem I'm encountering. Dist-git is great, and probably where we should be targeting. It has a lookaside fit the tarballs and such. Why is this not good enough? Can the lookaside be adjusted to use the same tarballs? I wrote something back when I was working on GoOSe that would have been able to be flexible enough for this concept.</p>
<p dir="ltr">My knowledge of Tito is not enough to say for sure, but it should be able to either pull a tarball, or modify the spec in a way to deal with those changes. </p>
<p dir="ltr">Essentially, I don't see why the process can't accommodate the automation bits, but also make it easy for a contributor. In fact, maybe downloading the tarball, then telling Tito might be a good choice.</p>
<p dir="ltr">My suggestion here is to update Tito to accommodate an already existing tarball, either downloaded it in the lookaside cache. In the meantime, don't change your process.</p>
<p dir="ltr">Thoughts?</p></blockquote><div>+1, spot on of what I was thinking as well </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Sep 15, 2016 20:51, "Jason DeTiberus" <<a href="mailto:jdetiber@redhat.com" target="_blank">jdetiber@redhat.com</a>> wrote:<br type="attribution"></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 15, 2016 at 5:55 PM, Troy Dawson <span dir="ltr"><<a href="mailto:tdawson@redhat.com" target="_blank">tdawson@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
I've been debating this all week and decided it's probably better as a<br>
community decision than just my own.<br>
<br>
Problem:<br>
The current source rpm for origin is generated using tito on the<br>
origin git repo. The biggest problem with this is the tarball is<br>
generated on the fly and sortof encorporated into the spec file. That<br>
makes it hard for others to duplicate the src.rpm and/or make patches<br>
for it.<br>
<br>
If I were an outsider (not on the openshift team) and making an rpm<br>
for Fedora/EPEL, I wouldn't do this. I would grab the released<br>
tarball from Github and build my spec file around that.<br>
<br>
Solution 1:<br>
Keep things the same.<br>
Do others really care that they can't duplicate the src.rpm without<br>
tito, as long as they can recompile it?<br></blockquote><div><br></div><div>Personally, I like this approach since it integrates with rhpkg/fedpkg very well. I'm not sure if CentOS has a similar tool that provides dist-git alongside koji, but I like the idea of being able to leverage the same spec file for all builds.</div><div><br></div><div>That said, I do wonder if providing a tool that could "convert" the tito managed spec file to one that can be run outside of tito would be beneficial.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Solution 2:<br>
Create a origin spec file that uses the tarball from Github.<br>
I've already done this. It works quite well. But it does involve<br>
some manual spec file editing.<br>
<br>
Troy<br>
p.s. I am totally fine either way. The only reason I've been debating<br>
this is because I keep having issues with tito making the whole<br>
src.rpm.<br></blockquote><div><br></div><div>cc'ing Devan Goodwin, since he knows a bit about tito. I'm also cc'ing Adam Miller, since I know he is packaging OpenShift Origin for Fedora.</div></div><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr">Jason DeTiberus<br></div></div>
</div></div>
<br></div></div><span class="">______________________________<wbr>_________________<br>
CentOS-devel mailing list<br>
<a href="mailto:CentOS-devel@centos.org" target="_blank">CentOS-devel@centos.org</a><br>
<a href="https://lists.centos.org/mailman/listinfo/centos-devel" rel="noreferrer" target="_blank">https://lists.centos.org/mailm<wbr>an/listinfo/centos-devel</a><br>
<br></span></blockquote></div></div>
<br>______________________________<wbr>_________________<br>
CentOS-devel mailing list<br>
<a href="mailto:CentOS-devel@centos.org">CentOS-devel@centos.org</a><br>
<a href="https://lists.centos.org/mailman/listinfo/centos-devel" rel="noreferrer" target="_blank">https://lists.centos.org/<wbr>mailman/listinfo/centos-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-== @ri ==-</div></div>
</div></div>