<div dir="ltr">Thanks Brian. Just tested calling a recheck from gerrit and it is working. <div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 10, 2016 at 8:03 AM, Brian Stinson <span dir="ltr"><<a href="mailto:brian@bstinson.com" target="_blank">brian@bstinson.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Sep 09 14:56, Brian Stinson wrote:<br>
> On Sep 09 13:56, Attila Darazs wrote:<br>
> > On 09/08/2016 07:05 PM, Attila Darazs wrote:<br>
> > > On 09/07/2016 07:56 PM, Adriano Petrich wrote:<br>
> > > > Thanks Brian!<br>
> > > ><br>
> > > > On Wed, Sep 7, 2016 at 3:44 PM, Brian Stinson <<a href="mailto:brian@bstinson.com">brian@bstinson.com</a><br>
> > > > <mailto:<a href="mailto:brian@bstinson.com">brian@bstinson.com</a>>> wrote:<br>
> > > ><br>
> > > > On Sep 07 13:56, Adriano Petrich wrote:<br>
> > > > > Hi folks<br>
> > > > ><br>
> > > > > Retriggering a job or trying to trigger it from gerrit is not<br>
> > > > working<br>
> > > > ><br>
> > > > > I'm getting a NullPointerException on<br>
> > > > ><br>
> > > > > Caused by: java.lang.NullPointerException<br>
> > > > > at<br>
> > > ><br>
> > > > com.sonyericsson.hudson.<wbr>plugins.gerrit.trigger.<wbr>hudsontrigger.<wbr>GerritTriggerParameters.<wbr>setOrCreateParameters(<wbr>GerritTriggerParameters.java:<wbr>447)<br>
> > > ><br>
> > > > > at<br>
> > > ><br>
> > > > com.sonyericsson.hudson.<wbr>plugins.gerrit.trigger.<wbr>hudsontrigger.EventListener.<wbr>createParameters(<wbr>EventListener.java:263)<br>
> > > ><br>
> > > > > at<br>
> > > ><br>
> > > > com.sonyericsson.hudson.<wbr>plugins.gerrit.trigger.<wbr>hudsontrigger.EventListener.<wbr>schedule(EventListener.java:<wbr>188)<br>
> > > ><br>
> > > > > at<br>
> > > ><br>
> > > > com.sonyericsson.hudson.<wbr>plugins.gerrit.trigger.<wbr>hudsontrigger.GerritTrigger.<wbr>retriggerThisBuild(<wbr>GerritTrigger.java:849)<br>
> > > ><br>
> > > > > at<br>
> > > ><br>
> > > > com.sonyericsson.hudson.<wbr>plugins.gerrit.trigger.<wbr>hudsontrigger.actions.<wbr>RetriggerAction.doIndex(<wbr>RetriggerAction.java:148)<br>
> > > ><br>
> > > > > at sun.reflect.<wbr>NativeMethodAccessorImpl.<wbr>invoke0(Native<br>
> > > > Method)<br>
> > > > > at<br>
> > > ><br>
> > > > sun.reflect.<wbr>NativeMethodAccessorImpl.<wbr>invoke(<wbr>NativeMethodAccessorImpl.java:<wbr>57)<br>
> > > ><br>
> > > > > at<br>
> > > ><br>
> > > > sun.reflect.<wbr>DelegatingMethodAccessorImpl.<wbr>invoke(<wbr>DelegatingMethodAccessorImpl.<wbr>java:43)<br>
> > > ><br>
> > > > > at java.lang.reflect.Method.<wbr>invoke(Method.java:606)<br>
> > > > > at<br>
> > > ><br>
> > > > org.kohsuke.stapler.Function$<wbr>InstanceFunction.invoke(<wbr>Function.java:320)<br>
> > > > > at<br>
> > > > org.kohsuke.stapler.Function.<wbr>bindAndInvoke(Function.java:<wbr>163)<br>
> > > > > at<br>
> > > ><br>
> > > > org.kohsuke.stapler.Function.<wbr>bindAndInvokeAndServeResponse(<wbr>Function.java:96)<br>
> > > ><br>
> > > > > at<br>
> > > > org.kohsuke.stapler.<wbr>IndexDispatcher.dispatch(<wbr>IndexDispatcher.java:26)<br>
> > > > > at org.kohsuke.stapler.Stapler.<wbr>tryInvoke(Stapler.java:746)<br>
> > > > ><br>
> > > > ><br>
> > > > ><br>
> > > > > It looks related to the gerrit plugin. and arrfab found this bug<br>
> > > > > <a href="https://issues.jenkins-ci.org/browse/JENKINS-31198" rel="noreferrer" target="_blank">https://issues.jenkins-ci.org/<wbr>browse/JENKINS-31198</a><br>
> > > > <<a href="https://issues.jenkins-ci.org/browse/JENKINS-31198" rel="noreferrer" target="_blank">https://issues.jenkins-ci.<wbr>org/browse/JENKINS-31198</a>> but I'm not<br>
> > > > sure on<br>
> > > > > what to do.<br>
> > > > ><br>
> > > > ><br>
> > > > > Right now gating is broken because of this<br>
> > > > ><br>
> > > > > Cheers,<br>
> > > > ><br>
> > > > > Adriano<br>
> > > ><br>
> > > > Hi All,<br>
> > > ><br>
> > > > If you use the Gerrit retrigger functionality, you can mitigate<br>
> > > > this by<br>
> > > > running jjb over your specs or by opening the job config in the web<br>
> > > > interface and hitting save. This is needed to pick up some new<br>
> > > > fields in<br>
> > > > the job config that were added by plugin updates.<br>
> > > ><br>
> > > > If you have any questions please let us know.<br>
> > ><br>
> > > Hi Brian,<br>
> > ><br>
> > > I have a question. :)<br>
> > ><br>
> > > The "recheck" functionality is broken. This is not the same as<br>
> > > "retrigger", we're looking for something in the comments like this:<br>
> > ><br>
> > > > trigger-on:<br>
> > > > - patchset-created-event<br>
> > > > - comment-added-contains-event:<br>
> > > > comment-contains-value: '(?i)^(Patch Set<br>
> > > > [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*(recheck)<wbr>'<br>
> > ><br>
> > > from here[1].<br>
> > ><br>
> > > i.e. when somebody writes 'recheck' as a comment the jobs should trigger<br>
> > > and it doesn't happen. This might be because of the update?<br>
> > ><br>
> > > I repushed the JJB changes a couple of times today, so that doesn't<br>
> > > solve the issue. It does seem to trigger on patchset creation though.<br>
> > ><br>
> > > When commenting "recheck" on this[2] for example, it should rerun this<br>
> > > job[3] but nothing happens. This was working fine until recently and we<br>
> > > didn't change the jenkins-job-builder package or the JJBs around this part.<br>
> > ><br>
> > > Jenkins Job Builder version: 1.6.1<br>
> > ><br>
> > > Do you see anything in the logs about this? Did something change around<br>
> > > the Gerrit Trigger?<br>
> > ><br>
> > > Best regards,<br>
> > > Attila<br>
> > ><br>
> > > [1]<br>
> > > <a href="https://github.com/rdo-infra/ci-config/blob/master/jenkins/jobs/tripleo-quickstart-triggers.yml#L98-L101" rel="noreferrer" target="_blank">https://github.com/rdo-infra/<wbr>ci-config/blob/master/jenkins/<wbr>jobs/tripleo-quickstart-<wbr>triggers.yml#L98-L101</a><br>
> > ><br>
> > > [2] <a href="https://review.openstack.org/#/c/364394/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/364394/</a><br>
> > > [3]<br>
> > > <a href="https://ci.centos.org/view/rdo/view/tripleo-gate/job/tripleo-quickstart-gate-master-delorean-quick-basic/" rel="noreferrer" target="_blank">https://ci.centos.org/view/<wbr>rdo/view/tripleo-gate/job/<wbr>tripleo-quickstart-gate-<wbr>master-delorean-quick-basic/</a><br>
> ><br>
> > We dug into this a bit more with Fabian this morning and he found NPE errors<br>
> > about this comment added issue: <a href="http://pastebin.centos.org/53421/" rel="noreferrer" target="_blank">http://pastebin.centos.org/<wbr>53421/</a><br>
> ><br>
> > After some more digging, I found that the new version of Gerrit Trigger[1]<br>
> > has this new feature:<br>
> ><br>
> > JENKINS-30821[2] - Add comment-added comment as job parameter (pull #295)<br>
> ><br>
> > Which looks exactly like the part that is trying to fetch the comment when a<br>
> > build was triggered by a comment and leads to an NPE. According to arrfab we<br>
> > have this version on the Jenkins. I think downgrading to 2.21.1 will solve<br>
> > the issue.<br>
> ><br>
> > Meanwhile we can't trigger on any comment like recheck, full-ci-check,<br>
> > images-ci-check. The good news is that probably we don't have a problem with<br>
> > REG_EXP based branches and we don't need to change our JJB.<br>
> ><br>
> > A.<br>
> ><br>
> > [1] <a href="https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger#GerritTrigger-Version2.22.0%28releasedAug172016%29" rel="noreferrer" target="_blank">https://wiki.jenkins-ci.org/<wbr>display/JENKINS/Gerrit+<wbr>Trigger#GerritTrigger-<wbr>Version2.22.0%<wbr>28releasedAug172016%29</a><br>
> > [2] <a href="https://issues.jenkins-ci.org/browse/JENKINS-30821" rel="noreferrer" target="_blank">https://issues.jenkins-ci.org/<wbr>browse/JENKINS-30821</a><br>
><br>
> We should be able to get that plugin downgraded and pinned tonight. This<br>
> will require a SafeRestart of Jenkins (not a full outage window). I'll<br>
> let you all know how that goes.<br>
><br>
> --Brian<br>
<br>
</div></div>The plugins should be downgraded, can we try a trigger from gerrit?<br>
<div class="HOEnZb"><div class="h5"><br>
--Brian<br>
______________________________<wbr>_________________<br>
Ci-users mailing list<br>
<a href="mailto:Ci-users@centos.org">Ci-users@centos.org</a><br>
<a href="https://lists.centos.org/mailman/listinfo/ci-users" rel="noreferrer" target="_blank">https://lists.centos.org/<wbr>mailman/listinfo/ci-users</a><br>
</div></div></blockquote></div><br></div>