On Jun 10 09:19, Brian Stinson wrote:
On Jun 10 19:38, Ratnadeep Debnath wrote:
On Fri, Jun 10, 2016 at 6:44 PM, Brian Stinson brian@bstinson.com wrote:
Hi Folks,
Just a quick update, I'm still working on aligning some of the pieces here. There were a few things that changed independently that caused some issues (one of them being a tweak in the way Github handles collaborator permissions).
I should have updated instructions shortly.
Apologies for the delay.
Cool! Looking forward for the update. However, I have got a doubt. How do you plan to share the secret to access the webhook endpoint. Without it, we are getting 403 response from the ghprb webhook endpoint.
Thanks,
Ratnadeep Debnath, https://www.waartaa.com GPG Fingerprint: 033C 8041 A0E9 CDBA 2E02 B785 2119 5486 F245 DFD6
Adding users as collaborators does not require a webhook secret (although we will eventually support this).
-- Brian
Ok, I believe this issue should be sorted out. The biggest externally-facing issue was a typo in the wiki instructions, be sure your webhooks match this URL exactly (including the trailing slash): https://ci.centos.org/ghprbhook/
This will help those of you who were seeing 403 Errors in the webhook response with a 'No valid crumb...' message.
Cheers! -- Brian