On Fri, Mar 22, 2019 at 4:43 AM Pasi Kärkkäinen <pasik@iki.fi> wrote:
On Tue, Mar 12, 2019 at 01:21:01PM +0200, Pasi Kärkkäinen wrote:
> >
> > On Mon, Mar 04, 2019 at 04:22:19PM -0500, Karl Johnson wrote:
> > >      >
> > >      > I updated my PR: [3]https://github.com/CentOS-virt7/xen-kernel/pull/18
> > >
> > >      Hi Karl, I've build and tested your PR, but without the GCC7 patch, and
> > >      when I've tested it on el6, none of the guests had network access.
> > >      I had to revert the bridge changes to have them working
> > >      (CONFIG_BRIDGE_NETFILTER=m and CONFIG_BRIDGE=m).
> > >
> > >      Why did you want the BRIDGE built-in instead of a module?
> > >
> > >      Maybe you have something to setup the bridge (probably filter) properly,
> > >      or maybe something is different in the xen package between el6 and el7.
> > >      Any idea?
> > >
> > >      I still have to investigate the Xen pkg, and have a closer look at those
> > >      tests I'm running.
> > >
> > >    Hum strange. I switched from module to built-in because I always had a
> > >    deprecated warning about bridge when booting CentOS 6 (and I guess
> > >    everyone needs bridge?). I don't remember what was the exact warning
> > >    because it's been a long time since I switched it. I don't mind to put it
> > >    back as a module, both works for me but the warning is gone when built-in.
> >
> > Yeah better to keep things as modules, like they have been.
> >
> > btw upstream Linux 4.9 LTS kernel is now at 4.9.162 :)
> >
>
> I suggest we:
>
> 1) Rebase to linux 4.9.162.
> 2) Drop the "set bridge to built-in instead of module" changes. Let's keep those settings like they were earlier.
> 3) Drop the use of gcc7 for now.
>
> How does that sound?
>

Karl: Would you like to update the github PR ? Or should someone else pick up the kernel update work?


Thanks,

-- Pasi



Sure, I will update the PR in the next few days.

Karl