[CentOS-devel] import patch for centos-git-common/show_possible_srpms.sh

Nico Kadel-Garcia

nkadel at gmail.com
Sat Jul 5 16:43:36 UTC 2014


I'd mentioned this in a previous note, on a thread that got long:

> 2) The "show_possible_srpms.sh" script relies on checking for the word
> "import" in the git logs to determine SRPM versions, embedded in the
> git logs themselves. This raises the risk of *any* commit that uses
> that word for other reasons to report an invalid  SRPM version number.

I tried to submit this at bugs.centos.org, but there's not a category
there for 'centos-git-common' that I could easily find. The patch is
below:

diff --git a/show_possible_srpms.sh b/show_possible_srpms.sh
index 5f5fb93..d296449 100755
--- a/show_possible_srpms.sh
+++ b/show_possible_srpms.sh
@@ -110,7 +110,7 @@ if [[ "x${BRANCH}" != 'x' ]]; then
     LOGARGS="${LOGARGS} ${BRANCH}"
 fi

-loglist=$(git log ${LOGARGS} |grep import)
+loglist=$(git log ${LOGARGS} |grep '|\\import ')
 if [[ $? -ne 0 ]]; then
     exit 1
 fi



More information about the CentOS-devel mailing list