On 11/11/2014 03:01 AM, Elias Persson wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2014-11-10 15:43, Pat Riehecky wrote: >> +test_nodist=$(echo ${test_nvr} | sed -e 's/-[a-zA-Z0-9\.]*$//') >> +git_nodist=$(echo ${git_nvr} | sed -e 's/-[a-zA-Z0-9\._]*$//') > Why not `test_nodist="${foo_nvr%-*}"`? > >> + git_name=$(echo ${git_nvr} | cut -d '-' -f 1) + >> test_name=$(echo ${test_nvr} | cut -d '-' -f 1) > Why not `test_nodist="${foo_nvr%%-*}"`? Mostly personal preference, I've never found that syntax terribly self explanatory. For new users, that syntax is nearly impossible to search for online. Pat > > - -- > AF24 6DE9 D1DF DFB8 3A74 A7AC F457 B7A3 5DF1 4240 > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBAgAGBQJUYdBaAAoJEPRXt6Nd8UJALpMP/0O6skW1jgWFNl1T2zAtf67f > MR9v3+9y2quMCxUAXOEAC4G7PeXV+VACgoHSwBqlkIB/2bLYxpXptMS2ezdnhWNI > vncpYDcuxtbWWplSOsibVRQPq3H1xJyPCflVCyWn2fooRDhEfRR1imRUDmcQhw+E > USdmKvdu6A1iPiHqF5A142Mxy2qWjGjWMksGM+E3XD8rql6pl4WieNMjNm6imNZn > fdivJahc84Ba9TmXR8qsABBZKjq+UAwAyvXyB2Oho1+xntJh/hG0VvEfGSSGYxZd > 3YAc+lnzRr7OB11kA0uXmFlnrrGzjTtzXJbnK8mcmINBGsC6ZQ9zR9Kjg0q96y3x > 1ZJl841em7++lATKdjOOJMSN/2KUxi+rdCQEuZUi92MAAz2mCuBpcHf6KysVKkP1 > 4IhBBaooIolFLCTN8ZtDTjB5v18LhHQf55/q+vLnO8acgaxTWoT2iAFwA86x9KHm > uaOxyI+miLRif+cOZhjoufPNg80iLzK+Qq2avz8+4YpzhFGsjNN0hyA3uJlRUzPV > IZTLkdOMb2Ii41ijJWhskTJhidZ/Nz7zuszTQh8B11AVuEwoL3K8Md/yRQykmen0 > jILucOgj/y31JN8vfoCHoqbGhOLwBgs2gRSYA8UVaZRyxIr2VOQcfVSD6U6Yeyix > j85rCOpAu/OnP2LzVkjl > =4ju+ > -----END PGP SIGNATURE----- > _______________________________________________ > CentOS-devel mailing list > CentOS-devel at centos.org > http://lists.centos.org/mailman/listinfo/centos-devel -- Pat Riehecky Scientific Linux developer http://www.scientificlinux.org/