[CentOS-devel] [PATCH] Update API path in centos.git.repolist.py
Brian Stinson
brian at bstinson.com
Mon Jun 26 13:29:13 UTC 2017
On Jun 23 13:36, Pat Riehecky wrote:
> ---
> centos.git.repolist.py | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/centos.git.repolist.py b/centos.git.repolist.py
> index 75122ae..e135ca7 100755
> --- a/centos.git.repolist.py
> +++ b/centos.git.repolist.py
> @@ -13,7 +13,7 @@ import requests
> import simplejson as json
> import sys
>
> -RPCURL = "https://git.centos.org/rpc?req=LIST_REPOSITORIES"
> +RPCURL = "https://git.centos.org/rpc/?req=LIST_REPOSITORIES"
>
> def read_args():
> '''
> @@ -48,6 +48,11 @@ def get_repo_list(url, branch, projectpath):
> print err_msg
> sys.exit(1)
>
> + if req.status_code != 200:
> + print "Unable to access gitblit api at " + url
> + sys.exit(1)
> +
> +
> payload = req.text
> repos = json.loads(payload)
> branchname = 'refs/heads/' + branch
> @@ -68,6 +73,6 @@ def main():
> repos = get_repo_list(url=options.url, branch=options.branch, projectpath=options.project)
> if repos:
> print '\n'.join(repos)
> -
> +
> if __name__ == "__main__":
> main()
> --
> 1.8.3.1
>
> _______________________________________________
> CentOS-devel mailing list
> CentOS-devel at centos.org
> https://lists.centos.org/mailman/listinfo/centos-devel
This looks workable to me, happy to see this merged. Just curious
though, any reason to not call req.raise_for_status() in the try block
(after L46) instead of checking the exit code directly?
--Brian
More information about the CentOS-devel
mailing list