[CentOS-devel] CentOS Stream Pull Requests: How to know about them?

Carl George

carl at redhat.com
Wed Mar 3 15:24:43 UTC 2021


Some early contributors have used pull requests on git.centos.org to
demonstrate their changes, but also filed bugzillas to notify the
maintainers, linking to the respective pull request.  Functionally
this is the same as attaching a patch file to a bugzilla, just
presented slightly better.  The pull request cannot be merged
directly, and it's still up to the RHEL maintainer to take the patch
(either from a bugzilla attachment or appending .patch to the pull
request URL) and applying it to internal dist-git.

As others have stated, real mergeable pull requests are coming as part
of the 9 workflow.

On Wed, Mar 3, 2021 at 8:19 AM Brian Stinson <brian at bstinson.com> wrote:
>
>
> On Wed, Mar 3, 2021, at 08:08, Fabian Arrotin wrote:
> > On 03/03/2021 14:56, Miro Hrončok wrote:
> > > Hello CentOS!
> > >
> > > I've recently opened this Pull Request:
> > >
> > > https://git.centos.org/rpms/python-six/pull-request/1
> > >
> > > The only purpose was to see if the RHEL maintainers (my Red Hat team
> > > members) get notified. They were not.
> > >
> > > What is the supposed workflow here? There was no "CentOS" person who
> > > would respond to this Pull Request and the "RHEL persons" who could do
> > > something about this are not notified.
> > >
> > > Thanks,
> >
> > Hi Miro,
> >
> > Well, gitlab (https://gitlab.com/redhat/centos-stream) is where the
> > whole collaboration is supposed to happen (for Stream 9), and ideally
> > you'd have got the notification about it, but it's also "in progress"
> > (afaik)
> >
> > https://git.centos.org/ is actually only used for :
> > - push from Red Hat sources for el8/el8/el8s
> > - collaboration from SIGs (able to push to specific branches, but never
> > to c7/c8/c8s)
> >
> > --
> > Fabian Arrotin
> > The CentOS Project | https://www.centos.org
> > gpg key: 17F3B7A1 | twitter: @arrfab
> > _______________________________________________
> > CentOS-devel mailing list
> > CentOS-devel at centos.org
> > https://lists.centos.org/mailman/listinfo/centos-devel
> >
>
> To add here, attaching patches to CentOS Stream 8 attached to a bugzilla is the smoothest way to contribute at this time. Like Fabian mentioned, this is not the the desired workflow we want for the future. Gitlab is how we're going to make Merge Requests real for Stream 9.
>
> --Brian
> _______________________________________________
> CentOS-devel mailing list
> CentOS-devel at centos.org
> https://lists.centos.org/mailman/listinfo/centos-devel



-- 
Carl George



More information about the CentOS-devel mailing list