John R. Dennison wrote: > On Sat, May 21, 2011 at 09:30:06AM +0200, Nicolas Thierry-Mieg wrote: >> Ljubomir Ljubojevic wrote: >>> for i in $(find . -type f | grep .rpm); do >> >>> rpmsign --addsign `find . -type f | grep .rpm | grep -v .zzz` >> >> just a small comment, grep uses regexps so this doesn't do what you want >> (eg the . is a wildcard char). Your script can break, silently (won't >> sign rpms whose name contains "any char followed by zzz") or not (will >> attempt to rpmsign eg myrpms.pl), with some particular file names. >> >> what you really want is files ending with .rpm, so: >> grep '\.rpm$' > > Why are people passing this off to grep? > > rpmsign --addsign $(find . -type f -name \*.rpm ! -name \*.zzz) agreed, using find alone is "another way to do it", although as stated by John Pierce the second -name is useless here. I was pointing out a flaw in the code and offering a correction using "the same way to do it".