Hi all,
[1] explains on the workflow to integrate a Github project with ci.centos.org to trigger builds on every commit or on a pull request. However, it misses to mention that we need a "secret key" to setup Webhook access to [2]. And, then users are left puzzled as to why the integration is not working. AFAIK, this secret key has to be created for a project by the admin of ci.centos.org and handed out to the project owner manually. This is not a great workflow for a new project to start using ci.centos.org as an alternative for Travis CI. Please feel free to correct me if I am wrong.
[1]: https://wiki.centos.org/QaWiki/CI/GithubIntegration [2]: https://ci.centos.org/ghbrphook
Thanks, rtnpro
Hi,
[1] explains on the workflow to integrate a Github project with ci.centos.org to trigger builds on every commit or on a pull request. However, it misses to mention that we need a "secret key" to setup Webhook access to [2]. And, then users are left puzzled as to why the integration is not working
I think this is exactly what I am bumping my head against atm. I have setup the integration as described and builds are triggered on commits and pull requests, but centos-ci seems not to be able to write back the build status. I can see an exception in the build logs.
AFAIK, this secret key has to be created for a project by the admin of ci.centos.org and handed out to the project owner manually
And how do I go about this? Do I need to create another issue in https://bugs.centos.org?
--Hardy
Hi,
[1] explains on the workflow to integrate a Github project with ci.centos.org to trigger builds on every commit or on a pull request. However, it misses to mention that we need a "secret key" to setup Webhook access to [2]. And, then users are left puzzled as to why the integration is not working
I think this is exactly what I am bumping my head against atm. I have setup the integration as described and builds are triggered on commits and pull requests, but centos-ci seems not to be able to write back the build status. I can see an exception in the build logs.
AFAIK, this secret key has to be created for a project by the admin of ci.centos.org and handed out to the project owner manually
And how do I go about this? Do I need to create another issue in https://bugs.centos.org?
--Hardy
On 09/06/16 18:17, Hardy Ferentschik wrote:
Hi,
[1] explains on the workflow to integrate a Github project with ci.centos.org to trigger builds on every commit or on a pull request. However, it misses to mention that we need a "secret key" to setup Webhook access to [2]. And, then users are left puzzled as to why the integration is not working
I think this is exactly what I am bumping my head against atm. I have setup the integration as described and builds are triggered on commits and pull requests, but centos-ci seems not to be able to write back the build status. I can see an exception in the build logs.
AFAIK, this secret key has to be created for a project by the admin of ci.centos.org and handed out to the project owner manually
And how do I go about this? Do I need to create another issue in https://bugs.centos.org?
I believe Brian was working on this yesterday, surprised not to see an update from him here. Let me ping him once he's online in a few hours.
regards
On Jun 10 13:25, Karanbir Singh wrote:
On 09/06/16 18:17, Hardy Ferentschik wrote:
Hi,
[1] explains on the workflow to integrate a Github project with ci.centos.org to trigger builds on every commit or on a pull request. However, it misses to mention that we need a "secret key" to setup Webhook access to [2]. And, then users are left puzzled as to why the integration is not working
I think this is exactly what I am bumping my head against atm. I have setup the integration as described and builds are triggered on commits and pull requests, but centos-ci seems not to be able to write back the build status. I can see an exception in the build logs.
AFAIK, this secret key has to be created for a project by the admin of ci.centos.org and handed out to the project owner manually
And how do I go about this? Do I need to create another issue in https://bugs.centos.org?
I believe Brian was working on this yesterday, surprised not to see an update from him here. Let me ping him once he's online in a few hours.
regards
-- Karanbir Singh +44-207-0999389 | http://www.karan.org/ | twitter.com/kbsingh GnuPG Key : http://www.karan.org/publickey.asc
Hi Folks,
Just a quick update, I'm still working on aligning some of the pieces here. There were a few things that changed independently that caused some issues (one of them being a tweak in the way Github handles collaborator permissions).
I should have updated instructions shortly.
Apologies for the delay.
--Brian
On Fri, Jun 10, 2016 at 6:44 PM, Brian Stinson brian@bstinson.com wrote:
Hi Folks,
Just a quick update, I'm still working on aligning some of the pieces here. There were a few things that changed independently that caused some issues (one of them being a tweak in the way Github handles collaborator permissions).
I should have updated instructions shortly.
Apologies for the delay.
Cool! Looking forward for the update. However, I have got a doubt. How do you plan to share the secret to access the webhook endpoint. Without it, we are getting 403 response from the ghprb webhook endpoint.
Thanks,
On Jun 10 19:38, Ratnadeep Debnath wrote:
On Fri, Jun 10, 2016 at 6:44 PM, Brian Stinson brian@bstinson.com wrote:
Hi Folks,
Just a quick update, I'm still working on aligning some of the pieces here. There were a few things that changed independently that caused some issues (one of them being a tweak in the way Github handles collaborator permissions).
I should have updated instructions shortly.
Apologies for the delay.
Cool! Looking forward for the update. However, I have got a doubt. How do you plan to share the secret to access the webhook endpoint. Without it, we are getting 403 response from the ghprb webhook endpoint.
Thanks,
Ratnadeep Debnath, https://www.waartaa.com GPG Fingerprint: 033C 8041 A0E9 CDBA 2E02 B785 2119 5486 F245 DFD6
Adding users as collaborators does not require a webhook secret (although we will eventually support this).
-- Brian
On Jun 10 09:19, Brian Stinson wrote:
On Jun 10 19:38, Ratnadeep Debnath wrote:
On Fri, Jun 10, 2016 at 6:44 PM, Brian Stinson brian@bstinson.com wrote:
Hi Folks,
Just a quick update, I'm still working on aligning some of the pieces here. There were a few things that changed independently that caused some issues (one of them being a tweak in the way Github handles collaborator permissions).
I should have updated instructions shortly.
Apologies for the delay.
Cool! Looking forward for the update. However, I have got a doubt. How do you plan to share the secret to access the webhook endpoint. Without it, we are getting 403 response from the ghprb webhook endpoint.
Thanks,
Ratnadeep Debnath, https://www.waartaa.com GPG Fingerprint: 033C 8041 A0E9 CDBA 2E02 B785 2119 5486 F245 DFD6
Adding users as collaborators does not require a webhook secret (although we will eventually support this).
-- Brian
Ok, I believe this issue should be sorted out. The biggest externally-facing issue was a typo in the wiki instructions, be sure your webhooks match this URL exactly (including the trailing slash): https://ci.centos.org/ghprbhook/
This will help those of you who were seeing 403 Errors in the webhook response with a 'No valid crumb...' message.
Cheers! -- Brian
On Thu, Jun 9, 2016, at 07:12 AM, Ratnadeep Debnath wrote:
[1] explains on the workflow to integrate a Github project with ci.centos.org to trigger builds on every commit or on a pull request.
I think https://lists.centos.org/pipermail/ci-users/2016-May/000255.html is also breaking this.
At least, you're not the only one unable to use GHPRB. I spent a little bit of time trying to use the raw github notification at least and then implementing setting the status myself[1], and while that worked, it had the problem that it built all old commits, and I'm not aware of a sane workaround for that.
[1] https://github.com/CentOS/sig-atomic-buildscripts/blob/master/centos-ci/jjb/...
-
Brian Stinson -
Colin Walters -
Hardy Ferentschik -
Karanbir Singh -
Ratnadeep Debnath