What is the preferred method for submitting patches from upstream projects ? I have two patches for libvirt-0.8.1.el6_0.6. One adds ESX 4.1 support to things like virt-v2v ( http://www.redhat.com/archives/libvir-list/2010-July/msg00480.html) and the second fixes the broken "virsh snapshot-create" ( https://bugzilla.redhat.com/show_bug.cgi?id=727709). All I did really was get them to work with the CentOS 6 version of libvirt.
Thanks - Trey
On 09/14/2011 01:30 AM, Trey Dockendorf wrote:
What is the preferred method for submitting patches from upstream projects ? I have two patches for libvirt-0.8.1.el6_0.6. One adds ESX 4.1 support to things like virt-v2v (http://www.redhat.com/archives/libvir-list/2010-July/msg00480.html) and the second fixes the broken "virsh snapshot-create" (https://bugzilla.redhat.com/show_bug.cgi?id=727709). All I did really was get them to work with the CentOS 6 version of libvirt.
For the base distro components these would need to come via RH's code. However, if you open issues at bugs.centos.org and offer to maintain the patches, they could go into the same components into the CentOSPlus repo.
- KB
On Tue, Sep 13, 2011 at 7:32 PM, Karanbir Singh mail-lists@karan.orgwrote:
On 09/14/2011 01:30 AM, Trey Dockendorf wrote:
What is the preferred method for submitting patches from upstream projects ? I have two patches for libvirt-0.8.1.el6_0.6. One adds ESX 4.1 support to things like virt-v2v (http://www.redhat.com/archives/libvir-list/2010-July/msg00480.html) and the second fixes the broken "virsh snapshot-create" (https://bugzilla.redhat.com/show_bug.cgi?id=727709). All I did really was get them to work with the CentOS 6 version of libvirt.
For the base distro components these would need to come via RH's code. However, if you open issues at bugs.centos.org and offer to maintain the patches, they could go into the same components into the CentOSPlus repo.
- KB
CentOS mailing list CentOS@centos.org http://lists.centos.org/mailman/listinfo/centos
Based on the bug report for the snapshot-create issue, it seems it's in libvirt 0.9.0 and that it's something that may be solved completely in Fedora 16. Is there a good way to find if a specific patch/fix has been applied upstream by Red Hat?
What goes into the maintenance of a patch? I'd be happy to do so, but I only know enough C to be able to work in patches / changes and track down compile errors, but not enough to have been the original person that finds these solutions.
Thanks - Trey
On 09/14/2011 01:59 PM, Trey Dockendorf wrote:
Based on the bug report for the snapshot-create issue, it seems it's in libvirt 0.9.0 and that it's something that may be solved completely in Fedora 16. Is there a good way to find if a specific patch/fix has been applied upstream by Red Hat?
grab the sources, look at the code. I hepe to have an easier way than that soon, stay tuned :)
What goes into the maintenance of a patch? I'd be happy to do so, but I only know enough C to be able to work in patches / changes and track down compile errors, but not enough to have been the original person that finds these solutions.
essentially, when you request a package be locally ( ie, in CentOS ) patched, we would need to copy that rpm over from the base distro into the CentOS Plus repo. Apply the patch, test it, release it. But that process needs to be re-done everytime there is an update to the rpm, as long as upstream does not fix the issue, change the expected behaviour to what you are proposing or remove / change functionality in a way that its no longer possible to support the patches. But while the patch is in circulation, it would mean that everytime there is an update from upstream, you would need to make sure the patch still applies, or adapt it to apply cleanly.
does this clear up the requirements a bit ?
- KB
On Wed, Sep 14, 2011 at 3:10 PM, Karanbir Singh mail-lists@karan.orgwrote:
On 09/14/2011 01:59 PM, Trey Dockendorf wrote:
Based on the bug report for the snapshot-create issue, it seems it's in libvirt 0.9.0 and that it's something that may be solved completely in Fedora 16. Is there a good way to find if a specific patch/fix has been applied upstream by Red Hat?
grab the sources, look at the code. I hepe to have an easier way than that soon, stay tuned :)
What goes into the maintenance of a patch? I'd be happy to do so, but I only know enough C to be able to work in patches / changes and track down compile errors, but not enough to have been the original person that finds these solutions.
essentially, when you request a package be locally ( ie, in CentOS ) patched, we would need to copy that rpm over from the base distro into the CentOS Plus repo. Apply the patch, test it, release it. But that process needs to be re-done everytime there is an update to the rpm, as long as upstream does not fix the issue, change the expected behaviour to what you are proposing or remove / change functionality in a way that its no longer possible to support the patches. But while the patch is in circulation, it would mean that everytime there is an update from upstream, you would need to make sure the patch still applies, or adapt it to apply cleanly.
does this clear up the requirements a bit ?
- KB
CentOS mailing list CentOS@centos.org http://lists.centos.org/mailman/listinfo/centos
That does, thanks. If you want to give me more details off-list I'd like to work on getting these patches into CentOS Plus. Also where could I begin looking to see if upstream RHEL has applied these to their releases?
Thanks - Trey
-
Karanbir Singh -
Trey Dockendorf