On 2016-07-26 12:58, Richard W.M. Jones wrote: > On Mon, Jul 25, 2016 at 11:48:10AM +0200, Zdenek Sedlak wrote: >> On 2016-07-25 10:17, Artem Sidorenko wrote: >>> From the commit message: >>>> In newer CentOS 7 versions /etc/redhat-release says that the distro is >>>> derived from RHEL, so we need to look at /etc/centos-release for >>>> actually identifying it as CentOS. >>> If I understand this right, this is not a bug related to ARM images, but >>> a general change in CentOS? >>> >>> Artem >>> >>> On 07/24/2016 04:13 PM, Richard W.M. Jones wrote: >>>> On Sun, Jul 24, 2016 at 12:31:37PM +0200, Artem Sidorenko wrote: >>>>> Hey Centos ARM list, >>>>> >>>>> As requested via twitter today [1], >>>>> >>>>> On the current Raspberry Pi 3 image the /etc/redhat-release isn't a >>>>> symlink to centos-release like on x86, but a file with "Derived from Red >>>>> Hat Enterprise Linux 7.2 (Source)" [2]. >>>>> >>>>> This might lead to errors in the OS auto detection, like with Chef [3]. >>>> Yup, this affected libguestfs >>>> (https://github.com/libguestfs/libguestfs/commit/1ff463e8692aae4313bd5b42bb6f09932bb63392). >>>> >>>> IMHO it's up to Chef to fix their OS detection like we did. >>>> >>>> Rich. >>>> >>> _______________________________________________ >>> Arm-dev mailing list >>> Arm-dev at centos.org >>> https://lists.centos.org/mailman/listinfo/arm-dev >> Hi, >> >> >> wouldn't be the checking of /etc/os-release file a better way, how to >> detect the distro, since CentOS/RHEL/OEL/SC 7 is using systemd? > Not necessarily, since we need to detect RHEL/CentOS releases > back to CentOS 3, not to mention dozens of other Linux distros, > Windows, *BSD, etc. Not all the world is systemd. Not all the > world is even Linux. > > However if os-release exists, we will use it in some circumstances. > > Rich. > Fair enough, I missed that this is a part of libguestfs :-) //Zdenek