[CentOS-devel] Introducing Centpkg (Comments requested)

[Mike McLean]

Awesome! Thanks for doing this.

Technical comments:
1) Not sure if we need all those directory rpmdefines. One of the nice
things about the CentOS layout is that you can just --define "_topdir $PWD"
and the rest of the dirs just fall into place.

2) I'm not sure about dead.package check in load_spec. We can't formally
adopted that indicator, and if we do, we would probably not put the
dead.package file in the SPECS dir. Probably either drop the check
entirely, or move it out in front of the loop and check for it in the top
directory.

3) Splitting in the metadata. I wonder if we shouldn't just use the default
whitespace split .split(None, 1) instead of splitting specifically on a
single space. It's a little more forgiving if someone tries to manually
edit a metadata file. Also removes the need for stripping.

4) NotImplemented. You have a number of overrides that raise
NotImplementedError. I think perhaps some of these (the non-koji ones)
would "just work" if we did not override them (or maybe I'm being overly
optimistic).


On Sat, Jun 14, 2014 at 3:07 AM, Brian Stinson <bstinson at ksu.edu> wrote:

> Greetings everyone,
>
> I spent a little bit of time to see if pyrpkg
> (https://fedorahosted.org/rpkg/) could help with the "building RPMS from
> a git repo" workflow. Pyrpkg includes methods that can interact with git
> (cloning, downloading sources etc), koji, and the local mock/rpmbuild
> build processes among other things. You may know pyrpkg better as the
> backend for fedpkg in Fedora.
>
> I have a very bare-bones configuration at
> https://bitbucket.org/bstinsonmhk/centpkg that I thought I would share.
> Is the community interested in such a tool? If so I'm happy to keep
> working on it, perhaps with the help of others who are interested?
>
> Cheers!
> Brian
>
> --
> Brian Stinson
> bstinson at ksu.edu | IRC: bstinson
> _______________________________________________
> CentOS-devel mailing list
> CentOS-devel at centos.org
> http://lists.centos.org/mailman/listinfo/centos-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.centos.org/pipermail/centos-devel/attachments/20140617/6aadcb94/attachment.html>