Good afternoon everyone, On Mon, 2019-05-13 at 14:00 +0200, Fabian Arrotin wrote: > - for rpm packages, like centos-logos or centos-indexhtml, you can > (as sig-artwork lead) already push to specific branch, so you can > already push with your user to c8-sig-artwork branch I made my first push to git.centos.org/rpms/centos-logos.git repo. The goal was to update freeipa login screen background to look as shown in https://wiki.centos.org/ArtWork/Motifs/CentOS8/Sketch4?action=show#head-64eb25344b8400edc01c542a1677bfee94da18df Here is the push process I went through (comments are welcome): - To clone the repo, didn't find any git:// or ssh:// URL in the web interface, only https://. So I cloned the repo using the https://. No issue here. - Made changes inside the SOURCES directory, created a new tar.xz file and used the lookaside_upload script to upload it. No issue here either: [al at localhost centos-logos]$ lookaside_upload -f SOURCES/centos-logos- 80.5.tar.xz -n centos-logos -b c8-sig-artwork [+] CentOS Lookaside upload tool -> Checking if file already uploaded [+] CentOS Lookaside upload tool -> Initialing new upload to lookaside [+] CentOS Lookaside upload tool -> URL : https://git.centos.org [+] CentOS Lookaside upload tool -> Source to upload : SOURCES/centos- logos-80.5.tar.xz [+] CentOS Lookaside upload tool -> Package name: centos-logos [+] CentOS Lookaside upload tool -> sha1sum: 19db430136555d7fc981a70e4925921414d250f9 [+] CentOS Lookaside upload tool -> Remote branch: c8-sig-artwork [+] CentOS Lookaside upload tool -> ====== Trying to upload ======= ####################################################################### ####################################################################### ############################################################## 100.0% File centos-logos-80.5.tar.xz size 25495564 CHECKSUM 19db430136555d7fc981a70e4925921414d250f9 stored OK [+] CentOS Lookaside upload tool -> Returned value: 0 [+] CentOS Lookaside upload tool -> Source should be available at https://git.centos.org/sources/centos-logos/c8-sig-artwork/19db430136555d7fc981a70e4925921414d250f9 - Created a new local branch named c8-sig-artwork and updated the .centos-logos.metadata file to set the checksum of the new tar.xz source file. Added and committed the changes locally: [al at localhost centos-logos]$ git add .centos-logos.metadata [al at localhost centos-logos]$ git commit .centos-logos.metadata - When tried to push committed changes, found the following error: [al at localhost centos-logos]$ git push --set-upstream origin c8-sig- artwork fatal: unable to access 'https://git.centos.org/rpms/centos-logos.git/' : The requested URL returned error: 403 - Then edited the .git/config file to change the https:// URL for an equivalent one, using ssh://. The .git/config file looks like the following: [al at localhost centos-logos]$ cat .git/config [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote "origin"] # url = https://git.centos.org/rpms/centos-logos.git url = ssh://git@git.centos.org/rpms/centos-logos.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "c8"] remote = origin merge = refs/heads/c8 [branch "c8-sig-artwork"] remote = origin merge = refs/heads/c8-sig-artwork - Tried to push again and voilà! [al at localhost centos-logos]$ git push --set-upstream origin c8-sig- artwork Enumerating objects: 3, done. Counting objects: 100% (3/3), done. Delta compression using up to 2 threads Compressing objects: 100% (3/3), done. Writing objects: 100% (3/3), 702 bytes | 702.00 KiB/s, done. Total 3 (delta 0), reused 0 (delta 0) remote: Performing pre-check... remote: Pre-check results in remote: Welcome to repoSpanner 0.5+10.e4df0439a0f696f71c1f2fee285dc2022d435839.el7.infra, node centos01.rpms.fedoraproject.org remote: Delta resolving finished remote: Validating objects... remote: Objects validated remote: Finishing hook runner preparation... remote: Telling hook runner to grab new contents... remote: Running pre-receive hook... remote: Pre-receive hook done remote: Running update hook... remote: Update hook done remote: Syncing objects... remote: Objects synced remote: Requesting push... remote: Push results in remote: Running post-receive hook... remote: ERROR: [u'git', u'rev-list', u'3f59ee823e352be2fe7bf1651d27a3e663110319', u'^HEAD'] =-- 128 remote: remote: fatal: bad revision '^HEAD' remote: remote: Sending to redis to send commit notification emails remote: Post-receive hook done To ssh://git.centos.org/rpms/centos-logos.git * [new branch] c8-sig-artwork -> c8-sig-artwork Branch 'c8-sig-artwork' set up to track remote branch 'c8-sig-artwork' from 'origin'. > From that point, you can ask PR (have to verify if one can open a PR > against a specific branch, c8 in this case, as it *can't* be master) > and Johnny can merge it, or just ask Johnny do it "manually" by "git > checkout c8, git merge c8-sig-artwork, git push" :) Tried to make the PR using the web interface, but it takes forever trying to find something (repo branches I guess) when clicked the OpenPR button. Here is a screenshot: https://drive.google.com/open?id=1JP7wehAfVGtOMBphyMRI9luQeNH3pfeL > Would that kind of framework work for you ? The more I know it, the more I like it :) Thanks! -- Alain Reguera Delgado <alain.reguera at gmail.com>