Hi!
Think I found a reference to the problem(s) I am seeing with xen-tpmfront in my setup on the net:
https://patchwork.kernel.org/patch/9485637/
This patch has not been officially entered and it is not included in the kernel provided in SIG virt either
Can we please get it in ?
Best Dag
Dag,
Thanks for tracking this down. Any chance you could send a PR to https://github.com/CentOS-virt7/xen-kernel?
Otherwise, Anthony or I will take a look when we get a chance.
Peace, -George
On Thu, Sep 13, 2018 at 10:41 AM Dag Nygren dag@newtech.fi wrote:
Hi!
Think I found a reference to the problem(s) I am seeing with xen-tpmfront in my setup on the net:
https://patchwork.kernel.org/patch/9485637/
This patch has not been officially entered and it is not included in the kernel provided in SIG virt either
Can we please get it in ?
Best Dag
CentOS-virt mailing list CentOS-virt@centos.org https://lists.centos.org/mailman/listinfo/centos-virt
On torsdag 13 september 2018 kl. 12:58:03 EEST George Dunlap wrote:
Dag,
Just verified after a lengthy compilation of the kernel that the patch really works and now I can see a TPM on the virtual side!
Thanks for tracking this down. Any chance you could send a PR to https://github.com/CentOS-virt7/xen-kernel?
I will definitely join that mailing list. Have a feeling this is not the last problem I will see :-)
Otherwise, Anthony or I will take a look when we get a chance.
But I would appreciate it if somebody used to the procedures would pick it up from here.
The patch was the following: =================================== diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c index 5aaa268..dd83a07 100644 --- a/drivers/char/tpm/xen-tpmfront.c +++ b/drivers/char/tpm/xen-tpmfront.c @@ -203,7 +203,7 @@ static int setup_ring(struct xenbus_device *dev, struct tpm_private *priv) return -ENOMEM; }
- rv = xenbus_grant_ring(dev, &priv->shr, 1, &gref); + rv = xenbus_grant_ring(dev, priv->shr, 1, &gref); if (rv < 0) return rv; ====================================
Best Dag
On Thu, Sep 13, 2018 at 1:42 PM Dag Nygren dag@newtech.fi wrote:
On torsdag 13 september 2018 kl. 12:58:03 EEST George Dunlap wrote:
Dag,
Just verified after a lengthy compilation of the kernel that the patch really works and now I can see a TPM on the virtual side!
Great!
Thanks for tracking this down. Any chance you could send a PR to https://github.com/CentOS-virt7/xen-kernel?
I will definitely join that mailing list. Have a feeling this is not the last problem I will see :-)
Otherwise, Anthony or I will take a look when we get a chance.
But I would appreciate it if somebody used to the procedures would pick it up from here.
It's not a mailing list, it's the public git repo for the xen kernel packages. :-)
As I said, Anthony or I will probably do it at some point (and I've also forwarded your mail to the upstream Linux Xen maintainers). But you sending a PR accomplishes a few things:
1. It gets things there faster 2. It gets you more familiar with the CentOS workflow, so that you can more easily send improvements / fixes in the future. :-)
-George
On torsdag 13 september 2018 kl. 15:50:11 EEST George Dunlap wrote:
On Thu, Sep 13, 2018 at 1:42 PM Dag Nygren dag@newtech.fi wrote:
But I would appreciate it if somebody used to the procedures would pick it up from here.
It's not a mailing list, it's the public git repo for the xen kernel packages. :-)
As I said, Anthony or I will probably do it at some point (and I've also forwarded your mail to the upstream Linux Xen maintainers). But you sending a PR accomplishes a few things:
- It gets things there faster
- It gets you more familiar with the CentOS workflow, so that you can
more easily send improvements / fixes in the future. :-)
Fair enough.
But the problem seems to be that I don't have push access to xen-kernel.git to create a new fork and a pull request for my changes.
And I am not familiar enough with git to do it in any other way...
Best Dag
-
Dag Nygren -
George Dunlap