It's a legacy from the original fedora rpm dating back many versions, back to when php was still using cvs. It's good practice to have a comment explaining where the file comes from, but I will update that line to the new svn one.
I've attached the fixed spec.
----- Original Message ----- From: James Hogarth Sent: 02/01/11 01:32 PM To: The CentOS developers mailing list. Subject: Re: [CentOS-devel] php53-pear.spec
On 1 February 2011 13:24, James Findley sixy@gmx.com wrote:
Ok, this time I actually did attach the spec....
Hmm a little more complicated ;)
The wget commented out doesn't actually hit anything (gets a 404) is this really needed?
Looks good at first glace - not set up a build env yet to check how it builds - but based on spec I'm happy to keep an eye on upstream and test/build as co-maintainer as per our IRC chat.
James _______________________________________________ CentOS-devel mailing list CentOS-devel@centos.org http://lists.centos.org/mailman/listinfo/centos-devel
On 1 February 2011 14:01, James Findley sixy@gmx.com wrote:
It's a legacy from the original fedora rpm dating back many versions, back to when php was still using cvs. It's good practice to have a comment explaining where the file comes from, but I will update that line to the new svn one.
I've attached the fixed spec.
Thanks James,
It's personal preference but when passing something on to another admin I tend to like stuff that can work in general than leave any possible misunderstandings...
From my point of view looks good at a look through....
I'm having a bit of a production system issue right now I'm having to deal with in the office but in the next few days I'll put together a build system to give it a run through here...
But again happy to keep an eye on upstream and co-maintain for centos-extras..
James
-
James Findley -
James Hogarth