From: Pat Riehecky riehecky@fnal.gov
I've found a few repos without a SOURCES directory.
For example, kpatch source cannot be fetched without this patch.
Pat Riehecky (1): Fixed so it works on kpatch golang-*
get_sources.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
From: Pat Riehecky riehecky@fnal.gov
--- get_sources.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/get_sources.sh b/get_sources.sh index 24e507c..ab816f2 100755 --- a/get_sources.sh +++ b/get_sources.sh @@ -19,10 +19,11 @@ if [ -f /etc/centos-git-common ]; then . /etc/centos-git-common fi
-if [ ! -e ${f} ] || [ ! -d .git ] || [ ! -d SOURCES ]; then +if [ ! -e ${f} ] || [ ! -d .git ] || [ ! -d SPECS ]; then echo 'You need to run this from inside a sources git repo' exit 1 fi +mkdir -p SOURCES br=$(cat .git/HEAD |awk -F'/' '{print $3}' ) while read a ; do fsha=$( echo ${a} | cut -f1 -d\ )
Hi Pat,
Mike and I were talking about this - it might be enough to just check for the metadata file and the .git, you agree ?
On 06/11/2014 04:21 PM, Pat Riehecky wrote:
From: Pat Riehecky riehecky@fnal.gov
I've found a few repos without a SOURCES directory.
For example, kpatch source cannot be fetched without this patch.
Pat Riehecky (1): Fixed so it works on kpatch golang-*
get_sources.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
CentOS-devel mailing list CentOS-devel@centos.org http://lists.centos.org/mailman/listinfo/centos-devel
My general preferences are for more aggressive and detailed checks.
For example, in the dist tag script there are extra checks that are, strictly speaking, unnecessary (lines 64-66).
Since shell scripts are difficult to generate unit tests, I tend towards extra stuff to hopefully make sure my behaviour is as expected.
Mike's quick patch for my typos shows my humanity and why my code _always_ needs extra error checking. :)
my $0.02, more sanity checks == better
Pat
On 06/11/2014 10:32 AM, Karanbir Singh wrote:
Hi Pat,
Mike and I were talking about this - it might be enough to just check for the metadata file and the .git, you agree ?
On 06/11/2014 04:21 PM, Pat Riehecky wrote:
From: Pat Riehecky riehecky@fnal.gov
I've found a few repos without a SOURCES directory.
For example, kpatch source cannot be fetched without this patch.
Pat Riehecky (1): Fixed so it works on kpatch golang-*
get_sources.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
CentOS-devel mailing list CentOS-devel@centos.org http://lists.centos.org/mailman/listinfo/centos-devel
Hi
On 06/11/2014 04:42 PM, Pat Riehecky wrote:
My general preferences are for more aggressive and detailed checks.
For example, in the dist tag script there are extra checks that are, strictly speaking, unnecessary (lines 64-66).
Since shell scripts are difficult to generate unit tests, I tend towards extra stuff to hopefully make sure my behaviour is as expected.
Mike's quick patch for my typos shows my humanity and why my code _always_ needs extra error checking. :)
my $0.02, more sanity checks == better
ok, SPECS/ would need to exist for it to be a centos git repo anyway, adding this in
Pat
On 06/11/2014 10:32 AM, Karanbir Singh wrote:
Hi Pat,
Mike and I were talking about this - it might be enough to just check for the metadata file and the .git, you agree ?
On 06/11/2014 04:21 PM, Pat Riehecky wrote:
From: Pat Riehecky riehecky@fnal.gov
I've found a few repos without a SOURCES directory.
For example, kpatch source cannot be fetched without this patch.
Pat Riehecky (1): Fixed so it works on kpatch golang-*
get_sources.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
CentOS-devel mailing list CentOS-devel@centos.org http://lists.centos.org/mailman/listinfo/centos-devel
-
Karanbir Singh -
Pat Riehecky