On Mon, 2007-05-21 at 21:52 -0400, Charlie Brady wrote:
On Mon, 21 May 2007, Matthew Albright wrote:
To get heartbeat 2.0.8 to build successfully for me on CentOS5, I needed to add a few BuildRequires to the spec file.
...
@@ -21,7 +21,7 @@ BuildPrereq: glib-devel, perl, iputils, /usr/bin/ssh, openssl-devel, libnet # libnet available from www.ultramonkey.org and others Requires: sysklogd, heartbeat-stonith = %{version}-%{release}, heartbeat-pils = %{version}-%{release} -BuildRequires: libgcrypt-devel, lm_sensors-devel, net-snmp-devel +BuildRequires: libgcrypt-devel, lm_sensors-devel, net-snmp-devel, glib2-devel, python-devel, pam-devel, gnutls-devel, curses-devel
I do need to build these in mock and analyze for hidden build requirements. I apologize for not doing so, but it is something I intend to do for all packages in CentOS-Extras / Plus. I'm sure you have found all of those for heartbeat, thanks.
I'd suggest that you list those as:
+BuildRequires: glib2-devel +BuildRequires: python-devel +BuildRequires: pam-devel +BuildRequires: gnutls-devel +BuildRequires: ncurses-devel
That is probably not a bad suggestion, but the heartbeat RPM that I use from upstream has them all in one line. As I maintain that as a diff, I guess I can do it either way ... but will probably stay with the upstream way for now. (Upstream being http://linux-ha.org).
As we are currently listed as the Enterprise Linux RPMs for heartbeat there ... I'd like to stay as close to upstream as possible.
Thanks, Johnny Hughes